Add ptrace support for any GPUArray
#350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 93.37% 93.18% -0.19%
==========================================
Files 40 41 +1
Lines 2685 2700 +15
==========================================
+ Hits 2507 2516 +9
- Misses 178 184 +6 ☔ View full report in Codecov by Sentry. |
ytdHuang
approved these changes
Dec 15, 2024
labay11
pushed a commit
to labay11/QuantumToolbox.jl
that referenced
this pull request
Dec 22, 2024
* Add `ptrace` support for any `GPUArray` * Add changelog --------- Co-authored-by: Yi-Te Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Thank you for contributing to
QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.make test.juliaformatted by running:make format.docs/folder) related to code changes were updated and able to build locally by running:make docs.CHANGELOG.mdshould be updated (regarding to the code changes) and built by running:make changelog.Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.
Description
The
ptracefunction was previously returning aCPUarray when the input object was aGPUone. That was caused by themapslicefunction which doesn't supportGPUarrays yet.Thus, I decided to write the
GPUkernel by myself, using KernelAbstractions.jl. This would allow the compatibility with all the GPU arrays, and not only the CUDA arrays.Moreover, the extension is automatically loaded when CUDA, OneAPI, Metal and the others are loaded, because GPUArrays.jl and KernelAbstractions.jl are direct dependencies of those packages.